[TableBody] Fix row selection re-render

mui · Jan 10, 2017 · 6b3ca64 · 6b3ca64 · ricardo-cantu · Feb 16, 2017
1 parent 653edea
commit 6b3ca64
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 9 deletions.
diff --git a/src/Table/TableBody.js b/src/Table/TableBody.js
@@ -129,15 +129,16 @@ class TableBody extends Component {
   }
 
   componentWillReceiveProps(nextProps) {
-    if (this.props.allRowsSelected && !nextProps.allRowsSelected) {
-      this.setState({
-        selectedRows: [],
-      });
-      // TODO: should else be conditional, not run any time props other than allRowsSelected change?
-    } else {
-      this.setState({
-        selectedRows: this.calculatePreselectedRows(nextProps),
-      });
+    if (this.props.allRowsSelected !== nextProps.allRowsSelected) {
+      if (!nextProps.allRowsSelected) {
+        this.setState({
+          selectedRows: [],
+        });
+      } else {
+        this.setState({
+          selectedRows: this.calculatePreselectedRows(nextProps),
+        });
+      }
     }
   }
 

diff --git a/test/integration/Table/MultiSelectTable.spec.js b/test/integration/Table/MultiSelectTable.spec.js
@@ -58,5 +58,17 @@ describe('<MultiSelectTable />', () => {
       ],
       'should uncheck all the checkboxes'
     );
+
+    wrapper.update();
+    assert.deepEqual(
+      wrapper.find('Checkbox').map((checkbox) => checkbox.props().checked),
+      [
+        false,
+        false,
+        false,
+        false,
+      ],
+      'should be invariant to update'
+    );
   });
 });