Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
  • Loading branch information
siriwatknp and oliviertassinari committed Jun 23, 2021
1 parent a86102d commit aad5b70
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### [Versions](https://material-ui.com/versions/
### [Versions](https://material-ui.com/versions/)

## 5.0.0-alpha.38

Expand All @@ -8,18 +8,15 @@ _Jun 23, 2021_

Big thanks to the 18 contributors who made this release possible. Here are some highlights ✨:

- 🚀 We have completed all the [breaking changes](https://github.com/mui-org/material-ui/issues/20012). The plan to release 5.0.0-beta.0 is on July 1st and will start to promote its usage over v4
- 🚀 We have completed all the [breaking changes](https://github.com/mui-org/material-ui/issues/20012). The plan to release 5.0.0-beta.0 is on July 1st and will start to promote its usage over v4.

### `@material-ui/core@5.0.0-alpha.38`

#### Breaking changes

- <!-- 05 --> [Menu] Use ButtonBase in MenuItem (#26591) @siriwatknp

- Change the default value of `anchorOrigin.vertical` to follow the Material Design guidelines. The menu now displays below the anchor instead of on top of it.
This conversation was marked as resolved by siriwatknp
Show conversation
You can restore the previous behavior with:
- Change the default value of `anchorOrigin.vertical` to follow the Material Design guidelines. The menu now displays below the anchor instead of on top of it. You can restore the previous behavior with:

```diff
<Menu
Expand All @@ -29,15 +26,14 @@ Big thanks to the 18 contributors who made this release possible. Here are some
+ }}
```

- The `MenuItem` component inherits the `ButtonBase` component instead of `ListItem`.
The class names related to "MuiListItem-\*" are removed and theming `ListItem` is no longer affecting `MenuItem`.
- The `MenuItem` component inherits the `ButtonBase` component instead of `ListItem`. The class names related to "MuiListItem-\*" are removed and theming `ListItem` is no longer affecting `MenuItem`.

```diff
-<li className="MuiButtonBase-root MuiMenuItem-root MuiListItem-root">
+<li className="MuiButtonBase-root MuiMenuItem-root">
```

- prop `listItemClasses` is removed, use `classes` instead.
- The prop `listItemClasses` was removed, you can use `classes` instead.

```diff
-<MenuItem listItemClasses={{...}}>
Expand All @@ -46,7 +42,7 @@ Big thanks to the 18 contributors who made this release possible. Here are some

- <!-- 09 --> [theme] Improve default breakpoints (#26746) @siriwatknp

The default breakpoints were changed to better match the common use cases. They also better match the Material Design guidelines. [Read more about the change](https://github.com/mui-org/material-ui/issues/21902)
The default breakpoints were changed to better match the common use cases. They also better match the Material Design guidelines. [Read more about the change](https://github.com/mui-org/material-ui/issues/21902).

```diff
{
Expand Down Expand Up @@ -152,6 +148,8 @@ Big thanks to the 18 contributors who made this release possible. Here are some
- <!-- 35 --> [system] Normalize api for `createBox` (#26820) @mnajdova

```diff
import { createBox } from '@material-ui/system';

-const styled = createBox(defaultTheme);
+const styled = createBox({ defaultTheme });
```
Expand Down

0 comments on commit aad5b70

Please sign in to comment.