casting MenuItem value, using onChange value param

mui · Apr 11, 2019 · b4b4971 · b4b4971
1 parent 678f857
commit b4b4971
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/docs/src/pages/demos/dialogs/MaxWidthDialog.js b/docs/src/pages/demos/dialogs/MaxWidthDialog.js
@@ -45,10 +45,10 @@ class MaxWidthDialog extends React.Component {
     this.setState({ open: false });
   };
 
-  handleMaxWidthChange = event => {
-    const maxWidth = event.target.value === 'false' ? false : event.target.value;
-
-    this.setState({ maxWidth });
+  handleMaxWidthChange = (event, value) => {
+    this.setState({
+      maxWidth: value,
+    });
   };
 
   handleFullWidthChange = event => {
@@ -86,7 +86,7 @@ class MaxWidthDialog extends React.Component {
                     id: 'max-width',
                   }}
                 >
-                  <MenuItem value="false">false</MenuItem>
+                  <MenuItem value={false}>false</MenuItem>
                   <MenuItem value="xs">xs</MenuItem>
                   <MenuItem value="sm">sm</MenuItem>
                   <MenuItem value="md">md</MenuItem>

diff --git a/docs/src/pages/demos/dialogs/MaxWidthDialog.tsx b/docs/src/pages/demos/dialogs/MaxWidthDialog.tsx
@@ -54,11 +54,10 @@ class MaxWidthDialog extends React.Component<MaxWidthDialogProps, MaxWidthDialog
     this.setState({ open: false });
   };
 
-  handleMaxWidthChange = (event: React.ChangeEvent<HTMLSelectElement>) => {
-    const maxWidth =
-      event.target.value === 'false' ? false : (event.target.value as DialogProps['maxWidth']);
-
-    this.setState({ maxWidth });
+  handleMaxWidthChange = (event: React.ChangeEvent<HTMLSelectElement>, value: any) => {
+    this.setState({
+      maxWidth: value as DialogProps['maxWidth'],
+    });
   };
 
   handleFullWidthChange = (event: React.ChangeEvent<HTMLInputElement>) => {
@@ -96,7 +95,7 @@ class MaxWidthDialog extends React.Component<MaxWidthDialogProps, MaxWidthDialog
                     id: 'max-width',
                   }}
                 >
-                  <MenuItem value="false">false</MenuItem>
+                  <MenuItem value={false as any}>false</MenuItem>
                   <MenuItem value="xs">xs</MenuItem>
                   <MenuItem value="sm">sm</MenuItem>
                   <MenuItem value="md">md</MenuItem>