[Switch] Fix DOM warning when type isn't checkbox or radio (#36170

)
mui · Feb 16, 2023 · ef3fb7e · ef3fb7e
1 parent c3d5d38
commit ef3fb7e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/mui-material/src/Switch/Switch.test.js b/packages/mui-material/src/Switch/Switch.test.js
@@ -92,6 +92,10 @@ describe('<Switch />', () => {
     expect(getByRole('checkbox')).to.have.property('checked', false);
   });
 
+  it('should not show warnings when custom `type` is provided', () => {
+    expect(() => render(<Switch type="submit" />)).not.toErrorDev();
+  });
+
   describe('with FormControl', () => {
     describe('enabled', () => {
       it('should not have the disabled class', () => {

diff --git a/packages/mui-material/src/internal/SwitchBase.js b/packages/mui-material/src/internal/SwitchBase.js
@@ -159,7 +159,7 @@ const SwitchBase = React.forwardRef(function SwitchBase(props, ref) {
         defaultChecked={defaultChecked}
         className={classes.input}
         disabled={disabled}
-        id={hasLabelFor && id}
+        id={hasLabelFor ? id : undefined}
         name={name}
         onChange={handleInputChange}
         readOnly={readOnly}