[test] Increase test coverage (#8908)

mui · Oct 30, 2017 · f26d8a2 · f26d8a2
1 parent 836c01c
commit f26d8a2
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 20 deletions.
diff --git a/src/Checkbox/Checkbox.spec.js b/src/Checkbox/Checkbox.spec.js
@@ -2,16 +2,23 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow, getClasses } from '../test-utils';
+import { createShallow, getClasses, createMount } from '../test-utils';
 import Checkbox from './Checkbox';
+import IndeterminateCheckBoxIcon from '../svg-icons/IndeterminateCheckBox';
 
 describe('<Checkbox />', () => {
   let shallow;
   let classes;
+  let mount;
 
   before(() => {
     shallow = createShallow({ dive: true });
     classes = getClasses(<Checkbox />);
+    mount = createMount();
+  });
+
+  after(() => {
+    mount.cleanUp();
   });
 
   describe('styleSheet', () => {
@@ -26,4 +33,11 @@ describe('<Checkbox />', () => {
     const wrapper = shallow(<Checkbox />);
     assert.strictEqual(wrapper.name(), 'withStyles(SwitchBase)');
   });
+
+  describe('prop: indeterminate', () => {
+    it('should render an indeterminate icon', () => {
+      const wrapper = mount(<Checkbox indeterminate />);
+      assert.strictEqual(wrapper.find(IndeterminateCheckBoxIcon).length, 1);
+    });
+  });
 });
diff --git a/src/Chip/Chip.spec.js b/src/Chip/Chip.spec.js
@@ -8,14 +8,21 @@ import CheckBox from '../svg-icons/CheckBox';
 import { createShallow, createMount, getClasses, unwrap } from '../test-utils';
 import Avatar from '../Avatar';
 import Chip from './Chip';
+import CancelIcon from '../svg-icons/Cancel';
 
 describe('<Chip />', () => {
   let shallow;
   let classes;
+  let mount;
 
   before(() => {
     shallow = createShallow({ dive: true });
     classes = getClasses(<Chip />);
+    mount = createMount();
+  });
+
+  after(() => {
+    mount.cleanUp();
   });
 
   describe('text only', () => {
@@ -154,19 +161,14 @@ describe('<Chip />', () => {
   });
 
   describe('prop: deleteIcon', () => {
-    let wrapper;
-
-    before(() => {
-      wrapper = shallow(
+    it('should fire the function given in onDeleteRequest', () => {
+      const wrapper = shallow(
         <Chip
           label="Custom delete icon Chip"
           onRequestDelete={() => {}}
           deleteIcon={<CheckBox />}
         />,
       );
-    });
-
-    it('should fire the function given in onDeleteRequest', () => {
       const onRequestDeleteSpy = spy();
       wrapper.setProps({ onRequestDelete: onRequestDeleteSpy });
 
@@ -177,6 +179,11 @@ describe('<Chip />', () => {
         'should have called the onRequestDelete handler',
       );
     });
+
+    it('should render a default icon', () => {
+      const wrapper = mount(<Chip label="Custom delete icon Chip" onRequestDelete={() => {}} />);
+      assert.strictEqual(wrapper.find(CancelIcon).length, 1);
+    });
   });
 
   describe('reacts to keyboard chip', () => {
@@ -202,16 +209,6 @@ describe('<Chip />', () => {
     });
 
     describe('escape', () => {
-      let mount;
-
-      before(() => {
-        mount = createMount();
-      });
-
-      after(() => {
-        mount.cleanUp();
-      });
-
       it('should unfocus when a esc key is pressed', () => {
         const ChipNaked = unwrap(Chip);
         const wrapper2 = mount(<ChipNaked classes={{}}>Text Chip</ChipNaked>);

diff --git a/src/Radio/Radio.spec.js b/src/Radio/Radio.spec.js
@@ -2,14 +2,21 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { getClasses } from '../test-utils';
+import { getClasses, createMount } from '../test-utils';
 import Radio from './Radio';
+import RadioButtonCheckedIcon from '../svg-icons/RadioButtonChecked';
 
 describe('<Radio />', () => {
   let classes;
+  let mount;
 
   before(() => {
     classes = getClasses(<Radio />);
+    mount = createMount();
+  });
+
+  after(() => {
+    mount.cleanUp();
   });
 
   describe('styleSheet', () => {
@@ -25,4 +32,11 @@ describe('<Radio />', () => {
       assert.strictEqual(Radio.displayName, 'Radio');
     });
   });
+
+  describe('prop: checked', () => {
+    it('should render a checked icon', () => {
+      const wrapper = mount(<Radio checked />);
+      assert.strictEqual(wrapper.find(RadioButtonCheckedIcon).length, 1);
+    });
+  });
 });
diff --git a/src/Table/TableSortLabel.spec.js b/src/Table/TableSortLabel.spec.js
@@ -2,18 +2,24 @@
 
 import React from 'react';
 import { assert } from 'chai';
-import { createShallow, getClasses } from '../test-utils';
+import { createShallow, createMount, getClasses } from '../test-utils';
 import TableSortLabel from './TableSortLabel';
 
 describe('<TableSortLabel />', () => {
   let shallow;
+  let mount;
   let classes;
 
   before(() => {
     shallow = createShallow({ dive: true });
+    mount = createMount();
     classes = getClasses(<TableSortLabel />);
   });
 
+  after(() => {
+    mount.cleanUp();
+  });
+
   it('should render TableSortLabel', () => {
     const wrapper = shallow(<TableSortLabel />);
     assert.strictEqual(wrapper.hasClass(classes.root), true, 'should have root class');
@@ -59,4 +65,10 @@ describe('<TableSortLabel />', () => {
       assert.strictEqual(icon.hasClass(classes.desc), false);
     });
   });
+
+  describe('mount', () => {
+    it('should mount without error', () => {
+      mount(<TableSortLabel />);
+    });
+  });
 });