Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RaisedButton] Rounded corners are not rounded. #1048

Closed
olegshilov opened this issue Jul 6, 2015 · 11 comments
Closed

[RaisedButton] Rounded corners are not rounded. #1048

olegshilov opened this issue Jul 6, 2015 · 11 comments
Labels
component: button This is the name of the generic UI component, not the React module!

Comments

@olegshilov
Copy link

Hello. I encountered the following problem. Rounded corners on rised button do not appear rounded.

screen shot 2015-07-06 at 21 38 14

How can I fix this?

@olegshilov olegshilov changed the title [RaisedButton] Round corners are not round. [RaisedButton] Rounded corners are not rounded. Jul 7, 2015
@jkruder
Copy link
Contributor

jkruder commented Jul 9, 2015

@olegshilov What browser are you seeing this in?

@olegshilov
Copy link
Author

@jkruder

  • Chrome 43.0.2357.132 (64-bit)
  • Firefox 39.0
  • Safari 8.0.7 (10600.7.12)

screen shot 2015-07-09 at 20 37 03

@jkruder
Copy link
Contributor

jkruder commented Jul 9, 2015

@olegshilov It should be working...you're using the latest versions of the browsers. Are you applying any custom styling/overriding the theme?

@olegshilov
Copy link
Author

@jkruder yes, I use a custom theme and override styles with style={{width: '100%'}}

@jkruder
Copy link
Contributor

jkruder commented Jul 9, 2015

Can you try your app without the style={width: '100%'}}? I just replicated on the demo site and it's very difficult to tell that there are rounded corners when the width is set to 100%. If you see rounded corners without the width we know that there is no issue with the stock buttons.

@olegshilov
Copy link
Author

@jkruder I have another button without 100% width and it look the same.
screen shot 2015-07-09 at 21 41 21

@jkruder
Copy link
Contributor

jkruder commented Jul 9, 2015

The button is definitely rounded. The border-radius is only at 2px. I think it's just difficult to see the radius with the dark colors. If you zoom in on the image you just sent you can see the border radius.

@hai-cea
Copy link
Member

hai-cea commented Jul 14, 2015

@olegshilov How are you setting the button's background color?

@olegshilov
Copy link
Author

@hai-cea Through a custom theme

@hai-cea
Copy link
Member

hai-cea commented Jul 14, 2015

Here's some of my research:

Your Colors
Retina
image

Non-Retina
image

Same button colors - Different background color
Retina
image

Non-Retina
image

I did notice that the buttons look fine on the theme customization page:
On Theme customization page
Retina
image

Non-Retina
image

After some digging I traced it back to a background color of white being set in the default theme:
https://github.com/callemall/material-ui/blob/master/src/styles/themes/light-theme.js#L98

I'll put in a fix for this.

@olegshilov
Copy link
Author

@hai-cea Thanks.

mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: button This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants