Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] option to make dialog non cancellable #1162

Closed
bryanlarsen opened this issue Jul 14, 2015 · 3 comments
Closed

[Dialog] option to make dialog non cancellable #1162

bryanlarsen opened this issue Jul 14, 2015 · 3 comments
Labels
bug 🐛 Something doesn't work

Comments

@bryanlarsen
Copy link
Contributor

There should be an option so that escape doesn't cancel the dialog.
@hai-cea
Copy link
Member

hai-cea commented Jul 14, 2015

Thanks @bryanlarsen. It looks like we just need to listen to the modal prop during esc key down.

@hai-cea hai-cea added the bug 🐛 Something doesn't work label Jul 14, 2015
@bryanlarsen
Copy link
Contributor Author

That would work for me. I assumed that there would be people who want a modal={true} and still cancel via escape, but if there isn't, that would be simpler.

mogii pushed a commit to mogii/material-ui that referenced this issue Jul 16, 2015
[Dialog]fix make dialog box non-cancellable mui#1162
66c7da4
hai-cea added a commit that referenced this issue Jul 17, 2015
@hai-cea
Merge pull request #1187 from mogii/master
f133473 
[Dialog]option to make dialog box non-cancellable #1162
@hai-cea
Copy link
Member

hai-cea commented Jul 17, 2015

Fixed with #1187

@hai-cea hai-cea closed this as completed Jul 17, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko
[InlineVariant] Do not update value on backdrop click (mui#1162)
790c7be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bryanlarsen @hai-cea @alitaheri @mogii