-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UMD package: export MaterialUI variable #12387
Comments
@tkrotoff This change sounds good to me. However, it's a breaking change. We gonna need to bump the version to v2. I'm adding it into the milestone 👍 |
This use case is OK: codepen.io => material-ui (with I don't know how to configure myLib to use Example code:
|
@tkrotoff We will definitely move forward and address this problem in v2! |
See UMD package: export MaterialUI variable mui/material-ui#12387
@oliviertassinari wow did not expect a release so soon! Can I make a PR to change this: https://github.com/mui-org/material-ui/blob/v3.0.0/packages/material-ui/scripts/rollup.config.js#L10 ? |
@tkrotoff What do you mean? This change is still planed for v4, in 3-4 months. |
Je suis un peu perdu : few days ago you were talking about a v2. I saw v3 was just released (could have been a good time to change this) and now talking about a v4. |
Yeah sorry for the confusion. v2 focus has just shifted to v4 for Q1 2019. |
You can definitely open a pull request now on master. We will just wait before merging it :). |
Currently to use Material-UI with codepen.io, JSFiddle... you have to write (see https://stackoverflow.com/q/50705423):
This is because the output name inside rollup.config.js is
'material-ui'
:https://github.com/mui-org/material-ui/blob/8013fdd36d40980ebb8f116f20e2843b781c0c39/packages/material-ui/scripts/rollup.config.js#L10
Instead it should be a name without
-
, something like'MaterialUI'
:rollup.config.js example:
https://github.com/tkrotoff/react-form-with-constraints/blob/b64119bee6ab80c77417a9284a704b380b81bf5e/packages/react-form-with-constraints/rollup.config.js#L19-L27
Related issue: #7621
The text was updated successfully, but these errors were encountered: