Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Control clickable prop irrespective of onClick Prop #13052

Closed
2 tasks
vilvaathibanpb opened this issue Oct 1, 2018 · 1 comment
Closed
2 tasks

[Chip] Control clickable prop irrespective of onClick Prop #13052

vilvaathibanpb opened this issue Oct 1, 2018 · 1 comment
Labels
component: chip This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@vilvaathibanpb
Copy link
Contributor

The Clickable property becomes true if an onClick prop is present in the chip currently. It would be great to make clickable props determine the click-ability of the chip irrespective of onClick props

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Click-ability of the chip should be determined only by clickable property

Current Behavior

It is also determined/overridden by onClick property. Though clickable is false, if onClick is present, Chip is always clickable

Steps to Reproduce

Though clickable is false, the chip is clickable because of presence of onClick prop
Link: https://codesandbox.io/s/38qj8xp0o1

Tech Version
Material-UI latest
React latest
Browser Chrome
@vilvaathibanpb
Copy link
Contributor Author

@oliviertassinari @mbrookes I am picking up this issue. will raise a PR soon

@oliviertassinari oliviertassinari added the component: chip This is the name of the generic UI component, not the React module! label Oct 1, 2018
vilvaathibanpb pushed a commit to vilvaathibanpb/material-ui that referenced this issue Oct 1, 2018
@vilvaathiban-sixt
Issue-mui#13052 clickable false prop
a160fe0
@vilvaathibanpb vilvaathibanpb mentioned this issue Oct 1, 2018
Merged
oliviertassinari pushed a commit to vilvaathibanpb/material-ui that referenced this issue Oct 23, 2018
@vilvaathiban-sixt @oliviertassinari
Issue-mui#13052 clickable false prop
3178274
@oliviertassinari oliviertassinari added the new feature New feature or request label Oct 23, 2018
oliviertassinari pushed a commit that referenced this issue Oct 23, 2018
@vilvaathibanpb @oliviertassinari
[Chip] Control clickable property (#13056)
ffe6ee3 
* Issue-#13052 clickable false prop

* let's merge
@akashmitra akashmitra mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliviertassinari @vilvaathibanpb