Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't get premium theme one pirate to work #14002

Closed
franz101 opened this issue Dec 25, 2018 · 3 comments
Closed

Can't get premium theme one pirate to work #14002

franz101 opened this issue Dec 25, 2018 · 3 comments
Labels
bug 🐛 Something doesn't work

Comments

@franz101
Copy link

Hi I always get the following error embedding the Home component:
TypeError: undefined is not an object (evaluating 'router.pathname') next

This probably related because no class names get passed on
@illuminist
Copy link

I think you should ask on the theme maker website instead because this isn't an issue about material-ui directly.

@oliviertassinari
Copy link
Member

@franz101 The link component targets Next.js replace it with your routing solution. As for the style, I agree, we should ship #13861.

@joshwooding joshwooding mentioned this issue Jan 5, 2019
Merged
3 tasks
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jan 6, 2019
mbrookes pushed a commit that referenced this issue Jan 7, 2019
@joshwooding @mbrookes
[Link] Add a Link component (#14093)
f4281a7 
<!-- Thanks so much for your PR, your contribution is appreciated! ❤️ -->

- [x] I have followed (at least) the [PR section of the contributing guide](https://github.com/mui-org/material-ui/blob/master/CONTRIBUTING.md#submitting-a-pull-request).

Closes #13861
Closes #14002

Demo: https://deploy-preview-14093--material-ui.netlify.com/style/links/

Potential Todos:
- [ ] Make the demo page better 
- [ ] Demo the inline property on `Typography`
@oliviertassinari
Copy link
Member

We have removed the custom Next.js Link to use the upcoming Link component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@illuminist @oliviertassinari @franz101