Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Button and Button Base include duplicate props #15794

Closed
2 tasks done
retyui opened this issue May 22, 2019 · 2 comments 路 Fixed by #15843
Closed
2 tasks done

[TS] Button and Button Base include duplicate props #15794

retyui opened this issue May 22, 2019 · 2 comments 路 Fixed by #15843
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@retyui
Copy link
Contributor

retyui commented May 22, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 馃

What is the source of truth?

Current Behavior 馃槸

Button has some similar props types as the ButtonBase

https://github.com/mui-org/material-ui/blob/ce65fa2a835f2fc76716584975a134059856dcfc/packages/material-ui/src/ButtonBase/ButtonBase.d.ts#L18-L20

https://github.com/mui-org/material-ui/blob/ce65fa2a835f2fc76716584975a134059856dcfc/packages/material-ui/src/Button/Button.d.ts#L8-L10

Steps to Reproduce 馃暪

no matter

Context 馃敠

no matter

Your Environment 馃寧

no matter

Tech Version
Material-UI v4.0.0
@joshwooding joshwooding added support: question Community support but can be turned into an improvement typescript and removed support: question Community support but can be turned into an improvement labels May 23, 2019
@eps1lon eps1lon added the good first issue Great for first contributions. Enable to learn the contribution process. label May 24, 2019
@eps1lon
Copy link
Member

eps1lon commented May 24, 2019

Good opportunity to get familiar with the type declarations in our codebase. PRs welcome.

@retyui
Copy link
Contributor Author

retyui commented May 24, 2019 •
edited

Also has duplicated props:

<IconButton/>:

https://github.com/mui-org/material-ui/blob/89687f38cae750650555772ba4d821c9084d8dfc/packages/material-ui/src/IconButton/IconButton.d.ts#L9-L10

<Fab/>:
https://github.com/mui-org/material-ui/blob/89687f38cae750650555772ba4d821c9084d8dfc/packages/material-ui/src/Fab/Fab.d.ts#L8-L10

@lychyi lychyi mentioned this issue May 25, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Buttons] Consolidate ripple props type declarations lychyi/material-ui
3 participants
@retyui @eps1lon @joshwooding