Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Buttons] Consolidate ripple props type declarations #15843

Merged
merged 4 commits into from May 25, 2019
Merged

[Buttons] Consolidate ripple props type declarations #15843

merged 4 commits into from May 25, 2019

Conversation

lychyi
Copy link
Contributor

@lychyi lychyi commented May 25, 2019

Fixes #15794

@mui-pr-bot
Copy link

mui-pr-bot commented May 25, 2019 •
edited

No bundle size changes comparing 35c9b8b...5546642

Generated by 🚫 dangerJS against 5546642

@eps1lon eps1lon added component: button This is the name of the generic UI component, not the React module! component: ButtonBase The React component. component: toggle button This is the name of the generic UI component, not the React module! typescript labels May 25, 2019
@eps1lon eps1lon changed the title Remove duplicate props from extensions of ButtonBaseType [Buttons] Consolidate ripple props type declarations May 25, 2019
@eps1lon eps1lon merged commit 9d4a0de into mui:master May 25, 2019
@eps1lon
Copy link
Member

eps1lon commented May 25, 2019

@lychyi Much appreciated. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! component: ButtonBase The React component. component: toggle button This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS] Button and Button Base include duplicate props
3 participants
@lychyi @mui-pr-bot @eps1lon