Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Down Menu's icon in RTL mode does not float left. #1661

Closed
alitaheri opened this issue Sep 16, 2015 · 4 comments · Fixed by #1674
Closed

Drop Down Menu's icon in RTL mode does not float left. #1661

alitaheri opened this issue Sep 16, 2015 · 4 comments · Fixed by #1674
Labels
component: menu This is the name of the generic UI component, not the React module!

Comments

@alitaheri
Copy link
Member

image

I understand that this can be fixed very easily by changing a few line here

Luckily the theme can handle the dir="rtl" propagation, thanks to @louy #1408.

But since the drop down menu is being re-written #1158 I'm not sure if I should open a pull request. Please consider fixing this too. Many thanks for you beautiful work.

Addresses: #1367
@louy
Copy link
Contributor

louy commented Sep 17, 2015

Does this fix you issue?
https://github.com/louy/material-ui/tree/rtl

@alitaheri
Copy link
Member Author

Yes @louy, thanks again. I'll wait for it to get merged with master.

@louy
Copy link
Contributor

louy commented Sep 17, 2015

Please keep this issue open until my PR is merged then. You're welcome 😊

@louy louy mentioned this issue Sep 17, 2015
Merged
@alitaheri alitaheri reopened this Sep 17, 2015
@alitaheri
Copy link
Member Author

Okay, I'll close it when your code is merged with master.

mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
@dmtrKovalenko
Improve input mask UX and a11y (mui#1661)
b223777 
* Add jest debug configuration

* Move jest config to separate file

* Change input mask generation logic

* Use new geFormatHelperText date-io method to generate helper text and placeholder

* Update @date-io/jalaali and @date-io/hijiri

* [docs] Update component demo titles

* Fix mask input  issues and update e2e tests

* Optimize new masked input for date range picker

* Remove meaningless comment

* Update component based tests

* Use auto injecting dependencies for hooks

* Remove maskChar prop

* Again remove `date` from the useEffect dependency in usePickerState

* Make keyboard input isFocused mutable ref instead of state
@zannager zannager added the component: menu This is the name of the generic UI component, not the React module! label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Full RTL support louy/material-ui
3 participants
@louy @alitaheri @zannager