You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the issues of this repository and believe that this is not a duplicate.
Summary 馃挕
An onClick prop should trigger a function each time any value (selected or not) is clicked.
Motivation 馃敠
I have a form that triggers a state change when the rating value is selected. If the user clicks on a already selected value, the function is not called and the form appears broken.
Upon investigating the source code I also noticed a small typo in Rating.js. On line 357 the variable is called itemDeciamlValue - no bug because it is replicated but still a typo nonetheless.
The text was updated successfully, but these errors were encountered:
There isn't really a problem as it stands. Currently the onChange will on trigger the callback only if the value changes. What i'm proposing is a new feature (onClick) that would trigger on every click.
I can fix the typo and take a stab at the onClick prop if you think it is a valid feature request
@jmaloon Thank for the reproduction, the onClick callback already exists and the onChange behavior is correct. I don't see any potential for improvement.
Summary 馃挕
An
onClick
prop should trigger a function each time any value (selected or not) is clicked.Motivation 馃敠
I have a form that triggers a state change when the rating value is selected. If the user clicks on a already selected value, the function is not called and the form appears broken.
Upon investigating the source code I also noticed a small typo in Rating.js. On line
357
the variable is calleditemDeciamlValue
- no bug because it is replicated but still a typo nonetheless.The text was updated successfully, but these errors were encountered: