[core] Batch small changes #18041
Merged
[core] Batch small changes #18041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Sebastian suggestion
Per Matt suggestion
oliviertassinari
added
the
umbrella
oliviertassinari
force-pushed
the
batch-small-changes-v8
branch
2 times, most recently
from
893ff36
to
d0b3d9f
Compare
oliviertassinari
force-pushed
the
batch-small-changes-v8
branch
from
d0b3d9f
to
e6984b6
Compare
Details of bundle changes.Comparing: c10b8e7...e6984b6
|
merceyz
reviewed
Oct 26, 2019
| @@ -72,33 +72,35 @@ const GridListTileBar = React.forwardRef(function GridListTileBar(props, ref) { | |||
| actionIcon, | |||
| actionPosition = 'right', | |||
| classes, | |||
| className: classNameProp, | |||
| className, | |||
| subtitle, | |||
| title, | |||
| titlePosition = 'bottom', | |||
| ...other | |||
| } = props; | |||
|
|
|||
| const actionPos = actionIcon && actionPosition; | |||
There was a problem hiding this comment.
If you inline this then optimize-clsx can produce smaller code
var actionPos = actionIcon && actionPosition;
clsx(classes.titleWrap, {
left: classes.titleWrapActionPosLeft,
right: classes.titleWrapActionPosRight
}[actionPos]);vs
clsx(classes.titleWrap, actionIcon && (actionPosition === 'left' ? classes.titleWrapActionPosLeft : classes.titleWrapActionPosRight));
There was a problem hiding this comment.
Thanks for the info. I think that we can revisit later.
mbrookes
approved these changes
Oct 26, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16 commits for this time (spotted answering issues the last 7 days). I hope there is nothing really important. I have noticed a few other possible quick wins, but they require standalone pull requests.
@deprecatedmention is no visible. I think that we hide the prop from the documentation (yes, it's a bit unfair for people that uses it) and usedeprecatedPropTypeonce we prepare v4 deprecations for v5.