Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for a 'true black' mode #23519

Open
1 task done
burtonator opened this issue Nov 14, 2020 · 6 comments
Open
1 task done

Support for a 'true black' mode #23519

burtonator opened this issue Nov 14, 2020 · 6 comments
Labels
design This is about UI or UX design, please involve a designer waiting for 👍 Waiting for upvotes

Comments

@burtonator
Copy link

MUI has a great dark mode but for mobile devices that support AMOLED a real true black mode is going to be needed.

True black is basically #000000 for the background so that there is no light coming from those pixels on amoled... the backlighting is essentially off.

Text is much more readable on ipad , android, etc.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Probably just another palette color set. Not a TON of work and if we do it before you guys do I'll add the changes to this bug.

Examples 🌈

https://www.google.com/search?q=twitter+true+black&rlz=1C5CHFA_enUS920US920&sxsrf=ALeKk001aTMV5VNl6O9t9gtBJraZdKp8cg:1605382573826&source=lnms&tbm=isch&sa=X&ved=2ahUKEwixj6qQ5ILtAhUDQ80KHac8D_sQ_AUoAnoECAwQBA&biw=1629&bih=925&dpr=2.2

Motivation 🔦

Just trying not to burn my eyes out. With the current dark mode it's still too light on ipad... would look a lot better with a true black mode.

@burtonator burtonator added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 14, 2020
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 14, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 14, 2020

The recommended colors are documented in https://material.io/design/color/dark-theme.html#ui-application. We still need to improve the dark theme with #18378, #18308, #18309, #22112. Regarding a true dark mode, feel free to customize the background color to be darker.

@burtonator
Copy link
Author

@oliviertassinari Can I suggest reopening this? I think there's a misunderstanding of the request.

What I'm suggesting is to ship with a 3rd palette which is 'black' mode which is just a new palette based on 'dark'.

This can be done by adjusting all the colors and then shifting down everything so that the contrast isn't too extreme.

I might even be able to do it via code ...

The bugs you listed seem tangential. Would be nice if they were fixed but not directly applicable here.

@oliviertassinari oliviertassinari added the waiting for 👍 Waiting for upvotes label Nov 15, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 15, 2020

@burtonator What do you think about we first iterate with theme object developers can copy & paste from this thread? Did you look into the changes required? It would be perfect to share the solution here. Then if we get more requests, we can move it to the source.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 15, 2020

I have linked this issue in #22485:

Capture d’écran 2020-11-15 à 20 38 37

by "second theme" we mean something that requires 3 months of work, starting from the unstyled components, not small tweaks that take 1 day :)

@burtonator
Copy link
Author

@oliviertassinari we might build this on our end as a 'black' mode just by changing the color scheme a bit. I think it's just / mostly about shifting everything down. The one hack might be the default app bar color but I think MUI v5 could fix it and make it easy since there's a more proper impl of elevations there.

If you keep this open I'll update it with the color codes and a screenshot once we are done.

@oliviertassinari
Copy link
Member

@burtonator This sounds great, please share the solution here once you have something that works well in your use case :).
@joshwooding has started to work on the elevation at #21748.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

2 participants