Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Sync default theme with the theme used by the documentation #22112

Closed
xclw2000 opened this issue Aug 8, 2020 · 6 comments · Fixed by #26541 or #26744
Closed

[docs] Sync default theme with the theme used by the documentation #22112

xclw2000 opened this issue Aug 8, 2020 · 6 comments · Fixed by #26541 or #26744
Labels
breaking change design: material This is about Material Design, please involve a visual or UX designer in the process discussion docs Improvements or additions to the documentation
Milestone

Comments

@xclw2000
Copy link

xclw2000 commented Aug 8, 2020

Take Button as example, your example color is #1976d2, but when show in CodeSandBox, it's color is #3f51b5
image
image

@xclw2000 xclw2000 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 8, 2020
@mbrookes mbrookes added support: question Community support but can be turned into an improvement and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 8, 2020
@mbrookes
Copy link
Member

mbrookes commented Aug 8, 2020

The documentation uses a custom theme. We've previously discussed aligning them in v5, though I don't recall where exactly. (Possibly another similar issue, of which this would be a duplicate...)

@oliviertassinari
Copy link
Member

@mbrookes I couldn't find any specific issue for this too, but we had https://trello.com/c/v7uLsyMB/2601-use-default-theme-in-docs.

@mbrookes
Copy link
Member

mbrookes commented Aug 8, 2020

You mention it in the linked issue #21040 (comment), so we didn't imagine it. 😄

@xclw2000
Copy link
Author

xclw2000 commented Aug 9, 2020

I resolved this with a global provider, thank you all

@oliviertassinari oliviertassinari added discussion and removed support: question Community support but can be turned into an improvement labels Aug 9, 2020
@oliviertassinari oliviertassinari added this to the v5 milestone Aug 9, 2020
@petrussola
Copy link

petrussola commented Oct 7, 2020

same here, would be helpful to align docs and reality, I was very confused for a while until I found this issue

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 8, 2020
@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Nov 14, 2020
@oliviertassinari oliviertassinari changed the title Primary color in CodeSandBox is different with your example [docs] Sync default theme with the theme used by the documentation Nov 14, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 13, 2021

I'm reopening as there is still one major color that the documentation overrides from the default theme:

https://github.com/mui-org/material-ui/blob/9acf8be6d2fd08210665c294830df3c85c014214/docs/src/modules/components/ThemeContext.js#L227-L229

This resonates with #25522 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change design: material This is about Material Design, please involve a visual or UX designer in the process discussion docs Improvements or additions to the documentation
Projects
None yet
4 participants