Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Save onBlur (free solo) #30521

Closed
2 tasks done
obsd opened this issue Jan 6, 2022 · 8 comments · Fixed by #36280
Closed
2 tasks done

[Autocomplete] Save onBlur (free solo) #30521

obsd opened this issue Jan 6, 2022 · 8 comments · Fixed by #36280
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@obsd
Copy link

obsd commented Jan 6, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

There is clearOnBlur I think it will be really good to add saveOnBlur, I saw many of my users write a text in freeSolo mode but forget to click enter.
I will be happy to create a PR for that if you want (solved it already on my local project)

Examples 🌈

When a user will turn on the saveOnBlur attribute the last value will be added to the values.

Motivation 🔦

I think it will help users use this component from what I saw especially in freeSolo mode users add a text but without Enter the value will not update

@obsd obsd added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 6, 2022
@siriwatknp siriwatknp added component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 7, 2022
@siriwatknp siriwatknp changed the title Save autocomplete onBlur [Autocomplete] Save onBlur (free solo) Jan 7, 2022
@siriwatknp
Copy link
Member

siriwatknp commented Jan 7, 2022

From my quick thought, it sounds like a good improvement for the free solo but do you see any concern for the usage that is not free solo?

@obsd
Copy link
Author

obsd commented Jan 8, 2022

In regular mode, it should check if the written word is equal to one of the options if it is, select it, if not clear/do nothing.
Or if we want to keep it simple it could be an option for freeSolo only.

This is what I think, would love to hear your thoughts about that as well...

I would love to contribute this code if you want @siriwatknp.

@siriwatknp
Copy link
Member

siriwatknp commented Jan 10, 2022

I think it makes sense to support saveOnBlur only for freeSolo mode. Feel free to submit a PR and tag me. Thanks!

@abhinav-22-tech
Copy link
Contributor

Hey, @obsd Is there any progress?

@Dentling
Copy link

Hello,
I just had the same thought and stumbled onto this issue.
@obsd Is there any progress by now?
Or would you be kind enough to show how you got it working on your local project?

@siriwatknp siriwatknp added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Jan 13, 2023
@WIH9
Copy link

WIH9 commented Feb 6, 2023

Hi @siriwatknp I'd to pick this up if it's still available.

@siriwatknp
Copy link
Member

Hi @siriwatknp I'd to pick this up if it's still available.

Sure! feel free to tag me in the PR.

@sai6855
Copy link
Contributor

sai6855 commented Feb 21, 2023

@siriwatknp created PR for this issue #36280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants