Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] remove window-listenable mixin from components #3305

Closed
9 tasks done
newoga opened this issue Feb 12, 2016 · 5 comments · Fixed by #3334
Closed
9 tasks done

[Core] remove window-listenable mixin from components #3305

newoga opened this issue Feb 12, 2016 · 5 comments · Fixed by #3334
Labels
umbrella For grouping multiple issues to provide a holistic view

Comments

@newoga
Copy link
Contributor

newoga commented Feb 12, 2016

Related to #2437.

Components:
@newoga newoga added Core umbrella For grouping multiple issues to provide a holistic view labels Feb 12, 2016
@alitaheri
Copy link
Member

This is great 👍 Thanks for doing this 😁

@newoga
Copy link
Contributor Author

newoga commented Feb 12, 2016

ES6 is slowly becoming more possible 😄

@alitaheri
Copy link
Member

Indeed 👍 👍

@rob0rt rob0rt mentioned this issue Feb 12, 2016
Closed
7 tasks
oliviertassinari added a commit that referenced this issue Feb 12, 2016
@oliviertassinari
Merge pull request #3309 from newoga/#3305/time-picker
e81c4af 
[TimePicker] Remove window-listenable mixin
oliviertassinari added a commit that referenced this issue Feb 12, 2016
@oliviertassinari
Merge pull request #3310 from newoga/#3305/dialog
f0fc7e7 
[Dialog] Remove window-listenable mixin
oliviertassinari added a commit that referenced this issue Feb 12, 2016
@oliviertassinari
Merge pull request #3306 from newoga/#3305/left-nav
956c200 
[LeftNav] Remove window-listenable mixin
oliviertassinari added a commit that referenced this issue Feb 12, 2016
@oliviertassinari
Merge pull request #3308 from newoga/#3305/popover
d4472ee 
[Popover] Remove window-listenable mixin
oliviertassinari added a commit that referenced this issue Feb 12, 2016
@oliviertassinari
Merge pull request #3307 from newoga/#3305/enhanced-switch
8df50a5 
[EnhancedSwitch] Remove window-listenable mixin
@newoga newoga mentioned this issue Feb 13, 2016
Merged
oliviertassinari added a commit that referenced this issue Feb 14, 2016
@oliviertassinari
Merge pull request #3329 from newoga/#3305/date-picker
3717d1d 
[DatePicker] Remove window-listenable mixin
@oliviertassinari oliviertassinari mentioned this issue Feb 14, 2016
Merged
@alitaheri
Copy link
Member

All that's left is to remove the mixin itself 😎

@alitaheri
Copy link
Member

O.O that was fast 😱

@newoga newoga mentioned this issue Apr 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Remove the WindowListenable mixin
2 participants
@newoga @alitaheri