Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fab] button disabled class (classes.disabled) is not working. #34227

Closed
2 tasks done
meenarama opened this issue Sep 8, 2022 · 3 comments · Fixed by #34245
Closed
2 tasks done

[Fab] button disabled class (classes.disabled) is not working. #34227

meenarama opened this issue Sep 8, 2022 · 3 comments · Fixed by #34245
Assignees
Labels
bug 🐛 Something doesn't work component: Fab The React component.

Comments

@meenarama
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

css for classes.disabled is not honored when the Fab button is disabled

Expected behavior 🤔

css for classes.disabled is honored when the Fab button is disabled

Steps to reproduce 🕹

Steps:

< Fab disabled classes={{ disabled: "my-disabled" }}>A Fab button</Button>
is not picking up the "my-disabled" styles when the Fab button is disabled

Context 🔦

I am trying add a style for disabled fab button

Your environment 🌎

System:
    OS: macOS 12.5.1
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: Not Found
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
  Browsers:
    Chrome: 105.0.5195.102
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.6.1
@meenarama meenarama added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 8, 2022
@meenarama
Copy link
Contributor Author

Probably, fab button needs to have the classes forwarded to buttonbase, just like button - https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Button/Button.js#L36 ?

@hbjORbj hbjORbj added component: Fab The React component. status: waiting for author Issue with insufficient information labels Sep 9, 2022
@hbjORbj
Copy link
Member

hbjORbj commented Sep 9, 2022

It doesn't look like this bug report has enough info for one of us to reproduce it.


Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.

Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

@hbjORbj hbjORbj removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 9, 2022
@hbjORbj hbjORbj self-assigned this Sep 9, 2022
@hbjORbj hbjORbj changed the title Fab button disabled class (classes.disabled) is not working. [Fab] button disabled class (classes.disabled) is not working. Sep 9, 2022
meenarama pushed a commit to meenarama/material-ui that referenced this issue Sep 9, 2022
@meenarama
Copy link
Contributor Author

@hbjORbj , this is similar to this defect - #25011. I have created a PR for this - #34245, could you kindly take a look.

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label Sep 9, 2022
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Sep 10, 2022
meenarama pushed a commit to meenarama/material-ui that referenced this issue Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Fab The React component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants