Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LeftNav] Make composable #413

Closed
puppybits opened this issue Mar 10, 2015 · 12 comments
Closed

[LeftNav] Make composable #413

puppybits opened this issue Mar 10, 2015 · 12 comments
Assignees
Labels
component: menu This is the name of the generic UI component, not the React module!

Comments

@puppybits
Copy link

Is there a way to make the LeftNav component composable? I need to add a custom component into the LeftNav. Is there a way to add another MenuItemType or pass in children into the render function on the LeftNav?

@eliquious
Copy link

++1

@clauderic
Copy link

Yeah I don't understand why this isn't the default behavior. +1

@TanTan-TT
Copy link

+1

@hai-cea hai-cea changed the title LeftNav isn't composable [LeftNav] isn't composable Jun 18, 2015
@hai-cea hai-cea changed the title [LeftNav] isn't composable [LeftNav] Make composable Jun 19, 2015
@CumpsD
Copy link
Contributor

CumpsD commented Jun 21, 2015

Would love to see this, I'm trying to apply additional styles to the Menu that is currently wrapped in LeftNav, but there doesn't seem to be a way?

@hai-cea hai-cea mentioned this issue Jun 27, 2015
@olivierGM
Copy link

+1
Did you guys figured a work around ?

@jkruder jkruder added this to the Composable Components milestone Jul 8, 2015
@olivierGM
Copy link

Also shouldn't the menu items of a leftnav be declared as elements instead of json passed as an attribute?

<LeftNav>
         <MenuItem 1/>
         <MenuItem 2/>
         <MenuItem 3/>
</LeftNav>

@cutemachine
Copy link

+1

@joebandenburg
Copy link
Contributor

+1

I'd go even further than @olivierGM's suggestion:

<LeftNav>
    <Menu>
        <Menu Item />
        ...
    </Menu>
</LeftNav>

This way I can put whatever content I like in there.

@yongxu
Copy link
Contributor

yongxu commented Aug 2, 2015

#1319 composable LeftNave

@bmanturner
Copy link

+1

1 similar comment
@michaelntech
Copy link

+1

@alitaheri
Copy link
Member

This is now possible with the improved LeftNav.

@alitaheri alitaheri modified the milestone: Composable Components Dec 23, 2015
brianfeister pushed a commit to brianfeister/material-ui that referenced this issue May 1, 2017
* Update dependecies, change component prop-types.

* Helmet now has prop-types support.

* Update yarn lockfile

* Bumped react-router and forgot prop types in clientconfig.

* Bump enzyme and prop-types

* Bump react-async-component and enzyme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests