Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Add the "Emergency" icon #41650

Closed
Justin-Luo opened this issue Mar 25, 2024 · 10 comments · Fixed by #41937 or #42080
Closed

[icons] Add the "Emergency" icon #41650

Justin-Luo opened this issue Mar 25, 2024 · 10 comments · Fixed by #41937 or #42080
Assignees
Labels
new feature New feature or request package: icons Specific to @mui/icons

Comments

@Justin-Luo
Copy link

Justin-Luo commented Mar 25, 2024

Steps to reproduce

Link to live example: (required)

Steps:
1.
2.
3.

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: emergency, icon

@Justin-Luo Justin-Luo added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 25, 2024
@zannager zannager added the package: icons Specific to @mui/icons label Mar 26, 2024
@CelestialWorthy
Copy link

emergency
something like this ?

@ZeeshanTamboli ZeeshanTamboli added new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 30, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title MUI missing "Emergency" icon [icons] MUI missing "Emergency" icon Mar 30, 2024
@CelestialWorthy
Copy link

CelestialWorthy commented Apr 2, 2024

What is the naming convention for the icons? I saw that material icons contain svg icons so do i just import it there ?

@CelestialWorthy
Copy link

on another note , do you think it is possible to add car logos as icons ?

@Justin-Luo
Copy link
Author

Following up, is this something that can be added soon?

@danilo-leal danilo-leal changed the title [icons] MUI missing "Emergency" icon [icons] Add the "Emergency" icon Apr 16, 2024
@Justin-Luo
Copy link
Author

@danilo-leal
Copy link
Contributor

@Justin-Luo It should've been added, but looking back again, it doesn't seem like it has 🤔 I've seen other instances (#39874) where the script to update the Material Icons wasn't picking up every new icon available there. Any pointers @siriwatknp or @michaldudak?

@michaldudak
Copy link
Member

The icon @Justin-Luo linked to is from Material Symbols, not Material Icons. Our library mirrors Material Icons, which doesn't contain the Emergency icon. If you'd like it to, please open an issue in the Material Icons repo.

@danilo-leal
Copy link
Contributor

🤨 The icon he's linking is from Material Icons, though, not from Symbols. That's why I thought it should've been picked up.

https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Aemergency%3A

@michaldudak
Copy link
Member

Sorry, I saw just the first link :/
The icons download script has a list of seemingly random exclusions (https://github.com/mui/material-ui/blob/next/packages/mui-icons-material/scripts/download.mjs#L14). I never fully understood the pattern here. I think it's safe to remove the emergency icon from this list and run the scripts again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons
Projects
None yet
7 participants