Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Port component #4783

Closed
4 tasks done
nathanmarks opened this issue Jul 21, 2016 · 2 comments
Closed
4 tasks done

[Autocomplete] Port component #4783

nathanmarks opened this issue Jul 21, 2016 · 2 comments
Labels
component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@nathanmarks
Copy link
Member

nathanmarks commented Jul 21, 2016 •
edited by oliviertassinari
Loading

Please rethink, redesign, rewrite.

  • Component
  • Tests (at least unit tests)
  • Docs
  • Demo
@nathanmarks nathanmarks added this to the 0.16.0 Release milestone Jul 21, 2016
This was referenced Sep 18, 2016
Closed
Closed
@oliviertassinari oliviertassinari mentioned this issue Jul 7, 2017
Closed
@oliviertassinari oliviertassinari modified the milestone: v1.0.0-prerelease Jul 14, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 17, 2017 •
edited
Loading

I have been playing around with react-autosuggest today of @moroshko. I have found this library pretty great. I think that we can provide an integration example or a small wrapper around it should be enough to close this issue and the other 55 issues.

It's accessible, well tested, lightweigh, well documented and allow enough customization power for us.

@oliviertassinari oliviertassinari mentioned this issue Jul 18, 2017
Closed
gorkemcnr pushed a commit to gorkemcnr/material-ui that referenced this issue Jul 19, 2017
mui#4783
fea465e 
- As discussed on mui#4393 and mui#4783 I have provided a fix for popover position issue on autocomplete.
@gorkemcnr gorkemcnr mentioned this issue Jul 19, 2017
Merged
@oliviertassinari oliviertassinari mentioned this issue Jul 19, 2017
Merged
3 tasks
This was referenced Jul 20, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@oliviertassinari oliviertassinari mentioned this issue Jul 20, 2017
Closed
@oliviertassinari oliviertassinari changed the title [AutoComplete] Port component [Autocomplete] Port component Jul 20, 2017
This was referenced Jul 20, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
oliviertassinari pushed a commit that referenced this issue Jul 21, 2017
@gorkemcnr @oliviertassinari
[Popover] Scroll Container issue (#7472)
4f2b78f 
* #4783
- As discussed on #4393 and #4783 I have provided a fix for popover position issue on autocomplete.

* Update Popover.js

* -Commented PR changes are applied
-Prop name is changed to a more meaningful name

* Update Popover.js

* Prop order is changed as alphabetical order

* redundant space removed

* redundant space is removed
@oliviertassinari oliviertassinari added component: autocomplete This is the name of the generic UI component, not the React module! and removed component: Autocomplete legacy labels Apr 29, 2020
chowdream added a commit to chowdream/Material-UI that referenced this issue Aug 17, 2023
@chowdream
[Popover] Scroll Container issue (#7472)
f5ecc63 
* #4783
- As discussed on mui/material-ui#4393 and mui/material-ui#4783 I have provided a fix for popover position issue on autocomplete.

* Update Popover.js

* -Commented PR changes are applied
-Prop name is changed to a more meaningful name

* Update Popover.js

* Prop order is changed as alphabetical order

* redundant space removed

* redundant space is removed
@Srikanth-PSIOG
Copy link

Srikanth-PSIOG commented Oct 25, 2023 •
edited
Loading

Is there any other solution than this wrapper? Seems like we are forced to use a wrapper even if the field is not MUI Autocomplete . Any findings for Mui Input or TextField? @oliviertassinari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @nathanmarks @Srikanth-PSIOG