Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define EnhancedTextarea hintText as string #6747

Closed
n-sviridenko opened this issue May 1, 2017 · 2 comments
Closed

Define EnhancedTextarea hintText as string #6747

n-sviridenko opened this issue May 1, 2017 · 2 comments
Labels
component: text field This is the name of the generic UI component, not the React module!

Comments

@n-sviridenko
Copy link

Hello! Is it possible to make hintText node instead of string? It's very useful for internationalisation using components (like react-intl).

https://github.com/callemall/material-ui/blob/v0.18.0/src/TextField/EnhancedTextarea.js#L37
@szchenghuang
Copy link

A related issue is thatTextField passes prop hintText to EnhancedTextArea. The former defines its type as PropTypes.node while the later expects PropTypes.string, resulting in the warning

Warning: Failed prop type: Invalid prop hintText of type object supplied to EnhancedTextarea, expected string.

@oliviertassinari
Copy link
Member

Hello! Is it possible to make hintText node instead of string?

Yes! Do you want to submit a PR 😄 ?

@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label May 2, 2017
@szchenghuang szchenghuang mentioned this issue May 4, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliviertassinari @szchenghuang @n-sviridenko