Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Fix a warning of 'Failed prop type' #6773

Conversation

szchenghuang
Copy link

TextField passes prop hintText to EnhancedTextArea. The former defines its type as PropTypes.node while the later expects PropTypes.string, resulting in the warning.

Fix #6747.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added PR: Review Accepted component: text field This is the name of the generic UI component, not the React module! and removed PR: Needs Review labels May 4, 2017
@oliviertassinari oliviertassinari merged commit 9ba4be3 into mui:master May 4, 2017
@oliviertassinari
Copy link
Member

@szchenghuang Thanks

@oliviertassinari oliviertassinari changed the title [TextField] Fix a warning of 'Failed prop type'. [TextField] Fix a warning of 'Failed prop type' May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants