Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Padding issue when setting dense and disablePadding at the same time #7515

Closed
stunaz opened this issue Jul 23, 2017 · 1 comment
Closed

[List] Padding issue when setting dense and disablePadding at the same time #7515

stunaz opened this issue Jul 23, 2017 · 1 comment
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@stunaz
Copy link
Contributor

stunaz commented Jul 23, 2017

Hi,

Setting dense and disablePadding at the same time to the List Component, results still having some padding.

Looks like dense styles overwrites disablePadding styles.

see this code https://github.com/callemall/material-ui/blob/v1-alpha/src/List/List.js#L18-L25

Any how to have disablePadding styles !important, not sure how it is done in jss...
@oliviertassinari oliviertassinari added component: list This is the name of the generic UI component, not the React module! v1 labels Jul 23, 2017
@oliviertassinari
Copy link
Member

I guess we only miss an extra logic with disablePadding here.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. labels Jul 24, 2017
@oliviertassinari oliviertassinari changed the title [List][V1] Padding issue when setting dense and disablePadding at the same time [List] Padding issue when setting dense and disablePadding at the same time Jul 24, 2017
@markselby9 markselby9 mentioned this issue Jul 24, 2017
Merged
3 tasks
oliviertassinari pushed a commit that referenced this issue Jul 24, 2017
@markselby9 @oliviertassinari
[List] Fix padding issue when setting dense and disablePadding at the…
32928c0 
… same time (#7515) (#7529)

Fix issue for: padding issue when setting dense and disablePadding at the same time (#7515)

Link: #7515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stunaz @oliviertassinari