Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Dark theme doesn't change AppBar color #859

Closed
odensc opened this issue Jun 16, 2015 · 3 comments
Closed

[AppBar] Dark theme doesn't change AppBar color #859

odensc opened this issue Jun 16, 2015 · 3 comments
Labels
component: app bar This is the name of the generic UI component, not the React module!

Comments

@odensc
Copy link

odensc commented Jun 16, 2015

When using the dark theme, the AppBar is still blue, which doesn't mix with the rest of the theme.

@hai-cea hai-cea changed the title Dark theme doesn't change AppBar color [AppBar] Dark theme doesn't change AppBar color Jun 19, 2015
@Zadielerick
Copy link
Contributor

#926

@odensc
Copy link
Author

odensc commented Jun 23, 2015

Teal 200 doesn't mix well either. I've been using Grey 800, like this:

import DarkTheme from "material-ui/lib/styles/themes/dark-theme";
import {Styles} from "material-ui";

// modified dark theme from mui to add missing stuff
let Dark = {
    getPalette: DarkTheme.getPalette,
    getComponentThemes(palette)
    {
        let themes = DarkTheme.getComponentThemes(palette);
        themes.appBar = {
            color: Styles.Colors.grey800
        };

        return themes;
    }
}

export default Dark;

@hai-cea
Copy link
Member

hai-cea commented Jun 24, 2015

@TheSBros Thanks for the feedback - we defaulted it to what was on the sticker sheet here:
https://www.google.com/design/spec/resources/sticker-sheets-icons.html

Of course, you can override this to be whatever you want - which it looks like you've done. 👍

@hai-cea hai-cea closed this as completed Jun 24, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this issue Nov 10, 2020
* Remove keycode in favour of event.key

Ref https://twitter.com/olivtassinari/status/1084819202412818432

We can already see size improvement (which will be visible for end user
only after material-ui upgrade) in 1.5kB.

* Fix test
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: app bar This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants