-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip element goes full-width in MS Edge #9615
Comments
Cc @mbrookes |
I take a look at styles and see that |
@IBestuzhev Good catch, then we gonna have to remove this style: |
@IBestuzhev What do you think of removing |
@oliviertassinari I discovered this fix as I have some
I think it's OK. The chip element is inline by design, so this solution looks natural. |
@IBestuzhev Do you want to submit a pull-request to update the implementation? |
No, I don't have any changes to |
@IBestuzhev The question was, do you want to apply that change to Chip and submit a PR? |
Not really, I don't feel myself skilled enough to provide the correct
tests for this.
…On Thu, Dec 28, 2017, 05:10 Matt Brookes ***@***.***> wrote:
@IBestuzhev <https://github.com/ibestuzhev> The question was, do you want
to apply that change to Chip and submit a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9615 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQz7edBBYv3SiK8DxUnNFYCqbWu-Z_gks5tEwaQgaJpZM4RMoPk>
.
|
When using the
Chip
element, behavior differs in browser. While in Chrome it has width calculated based on label and avatar, in MS Edge the element is 100% width. I did a CodeSandbox snippet to reproduce it.Expected Behavior
The
Chip
should be as narrow as its content, like it does in ChromeCurrent Behavior
On MS Edge (versions: Microsoft Edge 41.16299.15.0; Microsoft EdgeHTML 16.16299) the
Chip
element is full widthSteps to Reproduce (for bugs)
Chip
element to Appinline-flex
container (e.g.Badge
or custom div) fixes an issue.Context
I'm rendering a statistic page, where
Avatar
shows ID andlabel
displays aggregation data. I show each chip on new line (in a narrowGrid
element) so it's not a big problem, but in this case Avatar is not left-most.Your Environment
The text was updated successfully, but these errors were encountered: