Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add missing typescript dependency #10031

Merged
merged 2 commits into from Jan 27, 2018
Merged

[examples] Add missing typescript dependency #10031

merged 2 commits into from Jan 27, 2018

Conversation

quantuminformation
Copy link
Contributor

Add missing local dependency

@oliviertassinari oliviertassinari changed the title Update package.json [examples] Add missing typescript dependency Jan 25, 2018
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Jan 25, 2018
@@ -6,7 +6,8 @@
"material-ui": "next",
"react": "latest",
"react-dom": "latest",
"react-scripts-ts": "latest"
"react-scripts-ts": "latest",
"typescript": "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should technically go in devDependencies (and @types/react, @types/react-dom should be in dependencies).

@oliviertassinari
Copy link
Member

Something is off. I get warnings like this one trying to run the example.

capture d ecran 2018-01-25 a 22 53 00

@pelotom
Copy link
Member

pelotom commented Jan 25, 2018

I think this is a yarn issue. Try removing yarn.lock and then yarn again from scratch.

@oliviertassinari
Copy link
Member

Already tried. I will do it a second time.

@oliviertassinari
Copy link
Member

Nop, doesn't help. Maybe it's my environment?

@oliviertassinari oliviertassinari self-assigned this Jan 25, 2018
@pelotom
Copy link
Member

pelotom commented Jan 25, 2018

What this means IIRC is that more than one version (15, 16) of @types/react-dom is being resolved somehow.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 25, 2018

It could be a yarn cache issue on my end. As long as someone else can install it correctly, we are good to merge.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 27, 2018

@pelotom Figured it out. It was indeed a duplicated typing definition. The Material-UI root node_modules are conflicting with the examples folder. It should no longer be an issue when once we use a multipackage folder structure.

@oliviertassinari oliviertassinari merged commit e88b78a into mui:v1-beta Jan 27, 2018
@oliviertassinari
Copy link
Member

@quantuminformation Thank you for this first time pull-request :).

@quantuminformation
Copy link
Contributor Author

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants