New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Add missing typescript dependency #10031
Conversation
@@ -6,7 +6,8 @@ | |||
"material-ui": "next", | |||
"react": "latest", | |||
"react-dom": "latest", | |||
"react-scripts-ts": "latest" | |||
"react-scripts-ts": "latest", | |||
"typescript": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should technically go in devDependencies
(and @types/react
, @types/react-dom
should be in dependencies
).
I think this is a yarn issue. Try removing |
Already tried. I will do it a second time. |
Nop, doesn't help. Maybe it's my environment? |
What this means IIRC is that more than one version (15, 16) of |
It could be a yarn cache issue on my end. As long as someone else can install it correctly, we are good to merge. |
@pelotom Figured it out. It was indeed a duplicated typing definition. The Material-UI root |
@quantuminformation Thank you for this first time pull-request :). |
Happy to help! |
Add missing local dependency