[Popover] Should default to use anchorEl's parent body #10049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Jan 26, 2018
oliviertassinari
added
bug 🐛
ianschmitz
commented
Jan 26, 2018
src/Popover/Popover.js
Outdated
| * A node, component instance, or function that returns either. | ||
| * The `container` will passed to the Modal component. | ||
| */ | ||
| container: PropTypes.oneOfType([PropTypes.object, PropTypes.func]), |
There was a problem hiding this comment.
@oliviertassinari Just wanted to verify if this is the correct way to fix the no validation linting error message when we are intercepting props being passed through to child components.
There was a problem hiding this comment.
I noticed it gets added to the docs API page which doesn't seem right :(
There was a problem hiding this comment.
Looks good 👍 . Run yarn docs:api to update the docs.
oliviertassinari
changed the title
|
@ianschmitz Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10038.
The popover now defaults to using the parent body element of the
anchorElprop if acontainerprop isn't provided.