New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add utils section, document transitions #10239
Conversation
@mbrookes Great job! |
@oliviertassinari One thing I realised when working on this is that the name of the Collapse component is "backwards". All the other component names describe what the transition does when it is transitioning in (or can be used bidirectionally. I propose we rename Collapse to Expand. |
Some benchmark:
Collapse seems more "into the head" of people. |
It's that also true with |
Fade can be used bidirectionally - "fade in", "fade out". I can't think of anything better. |
A better benchmark: Generic:
Material Design:
JS:
CSS:
|
I'm against this change: |
Then shouldn't the |
Won't that makes it even more confusion? I would expect my element to be mounted when |
Which is why I originally proposed changing the name of the component - it does the opposite of what it says. So, change Grow to Shrink instead ? 😄 |
What about Zoom? The wording should allow people to visualise the type of animation. I don't think that the "in" or "out" aspect if it matter. The
|
"Fade in / out" |
Also move modals & popover docs to utils
Clean up API inheritance docs
Closes #10153