[core] Fix the es distribution #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `NODE_ENV=production` when `BABEL_ENV=es` should now allow production Babel transforms to be applied
NMinhNguyen
changed the title
oliviertassinari
changed the title
|
@NMinhNguyen Thanks for working on it. I have flattened the
This is a good thing. It avoids code duplication. I have subscribed to the following issues so we can improve the approach in the future: |
oliviertassinari
approved these changes
Feb 12, 2018
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can view the diff between the current and proposed build output here: https://github.com/NMinhNguyen/material-ui/commit/503bf240c24fa4bb3b9d00ff85b7a659d97f74a2
See #10212 (comment) for more context.
It's easier to review the individual commits by the way.
The main changes that concern me with this are things like
Object.keysbeing replaced withtransform-runtime, e.g. in https://github.com/NMinhNguyen/material-ui/commit/503bf240c24fa4bb3b9d00ff85b7a659d97f74a2#diff-d4e87d828003c3d0ed59409b821149b9R1. I suppose we could prevent this by not usingtransform-runtimeifENV === 'es'here?Closes #10212