[ClickAwayListener] Fix interaction with SVGElement #10318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in a situation when some <svg ... > element exists on page ClickAway() is not triggered because svg element is not an "instanceof HTMLElement"
oliviertassinari
changed the title
src/utils/ClickAwayListener.js
Outdated
| @@ -35,7 +35,7 @@ class ClickAwayListener extends React.Component { | |||
| const el = findDOMNode(this); | |||
|
|
|||
| if ( | |||
| event.target instanceof HTMLElement && | |||
| (event.target instanceof HTMLElement || event.target instanceof SVGElement) && | |||
There was a problem hiding this comment.
I believe this line was added to please flow type. We have removed flowtype since then. I think that it's safe to remove it. cc @rosskevin
|
@KEMBL Good catch 👍 |
rosskevin
approved these changes
Feb 16, 2018
|
@KEMBL It's a great first-time pull request 👌🏻. Thank you for giving it a shot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a situation when some <svg ... > element exists on page ClickAway() is not triggered because svg element is not an "instanceof HTMLElement"