[Transitions] Document transition style prop handling #10322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGorkoz
changed the title
1 task
mbrookes
previously requested changes
Feb 16, 2018
| To better support server rendering Material-UI provides a `style` property | ||
| to the children of some transition components (Fade, Grow, Zoom, Slide). | ||
| The `style` property is to be applied on the child components for the animation to work | ||
| as expected. |
There was a problem hiding this comment.
"The style property must be applied to the child component for the animation to work as expected."
oliviertassinari
approved these changes
Feb 16, 2018
|
@mbrookes @oliviertassinari Thanks for the review and for adding example , it makes it much clear what is required from the user. What is the process now ? how do i merge this ? |
mbrookes
approved these changes
Feb 17, 2018
|
@AdamGorkoz Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First ever contribution :)
Closes #10281