Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Ignore events generated by descendants #10372

Merged
merged 2 commits into from Feb 20, 2018
Merged

[Chip] Ignore events generated by descendants #10372

merged 2 commits into from Feb 20, 2018

Conversation

maxdubrinsky
Copy link
Contributor

Closes #10324

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module! labels Feb 20, 2018
@oliviertassinari oliviertassinari merged commit 018053f into mui:v1-beta Feb 20, 2018
@oliviertassinari
Copy link
Member

@maxdubrinsky It's a great first-time pull request 👌🏻. Thank you for giving it a shot! It's not every day that we see someone contributing a failing test and fixing it ✨ .

@maxdubrinsky maxdubrinsky deleted the chip-events-handling branch February 20, 2018 21:19
@maxdubrinsky
Copy link
Contributor Author

@oliviertassinari Thanks for the help, hope to be around here more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: chip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxdubrinsky @oliviertassinari