Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snackbar] Disable pausing of auto hide when window loses focus #10390

Merged
merged 1 commit into from Feb 21, 2018
Merged

[Snackbar] Disable pausing of auto hide when window loses focus #10390

merged 1 commit into from Feb 21, 2018

Conversation

SebastianSchmidt
Copy link
Contributor

Closes #10381

@oliviertassinari oliviertassinari added component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request labels Feb 21, 2018
mbrookes
mbrookes requested changes Feb 21, 2018
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a test. 👍

src/Snackbar/Snackbar.js Outdated
* focused.
*
* If `autoHideDuration` property isn't specified, it does nothing.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If true, the autoHideDuration timer will expire even if the window is not focused." is sufficient. Everything else can be inferred from that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 👍

@mbrookes mbrookes merged commit 0677901 into mui:v1-beta Feb 21, 2018
@mbrookes
Copy link
Member

@SebastianSchmidt Thanks! 👍

@SebastianSchmidt SebastianSchmidt deleted the 10381-snackbar-auto-hide-window-focus branch February 21, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SebastianSchmidt @mbrookes @oliviertassinari