Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve the onboarding #10639

Merged
merged 2 commits into from Mar 14, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 13, 2018

Brings what I can from #10616 to HEAD. The other branch might be on hold for quite some time.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 13, 2018
@mbrookes
Copy link
Member

mbrookes commented Mar 13, 2018

I'm no designer, but this feels like it should perhaps have consistent horizontal alignment between one column and two column sections:

screen shot 2018-03-14 at 00 47 36

@oliviertassinari oliviertassinari force-pushed the improve-onboarding branch 2 times, most recently from 45e4512 to 4fa413c Compare March 13, 2018 20:59
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 13, 2018

Any better idea?

@mui mui deleted a comment from mbrookes Mar 13, 2018
@oliviertassinari oliviertassinari added the new feature New feature or request label Mar 13, 2018
@oliviertassinari oliviertassinari self-assigned this Mar 13, 2018
@mbrookes
Copy link
Member

Perhaps put the installation and usage into Cards, so their sections have defined bounds, giving them equal visual weight.

Then remove all the excess text from the Sponsors section, put the gold sponsors side-by-side (centered) without reference to Patreon or OpenCollective or dollar amounts, then add a row below smaller logos of silver sponsors (I think it's a mistake not to mention Facebook on the home page).

Links to sponsorship platforms can go below that.

CT's logo could link to the free Material theme (for now), and in the interest of fairness, the CEA one should link probably to their site rather than OC.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 13, 2018

Perhaps put the installation and usage into Cards, so their sections have defined bounds, giving them equal visual weight.

It should be good like this. The imbalance will be address with the themes. I don't think that adding an elevation with a Paper will improve the situation. It look fine on Bootstrap side.

Then remove all the excess text from the Sponsors section

I have already tried to remove anything non-important.

put the gold sponsors side-by-side (centered) without reference to Patreon or OpenCollective

It's encouraging people to contribute first to Patreon then to OpenCollective.

then add a row below smaller logos of silver sponsors (I think it's a mistake not to mention Facebook on the home page)

It's giving them and other potential contributors to give more. I agree that having Facebook as a sponsor is a good thing. You can find them in https://material-ui.com/discover-more/backers/.

CT's logo could link to the free Material theme (for now), and in the interest of fairness, the CEA one should link probably to their site rather than OC.

The OpenCollective sponsors are handled by their CDN right now. The nice thing about it is that we have nothing to handle. New contributors will be added automatically, as well as being sorted by the total number of money they donated DESC.

@mbrookes
Copy link
Member

mbrookes commented Mar 14, 2018

@mbrookes
Copy link
Member

mbrookes commented Mar 14, 2018

The imbalance will be address with the themes.

Somewhat

I don't think that adding an elevation with a Paper will improve the situation. It look fine on Bootstrap side.

It isn't about elevation, it's about giving the containers a visible size so they appear more balanced when the content has differing visual weight. It works as well without the shadow. In fact, I just noticed Bootstrap have done the same.

I have already tried to remove anything non-important.

I think you're missing that the purpose of this section os to promote the sponsors. The sponsorship opportunity is implicit. Links to Patreon and OC is enough.

It's encouraging people to contribute first to Patreon then to OpenCollective.

Yes, I guessed the motivation. It's taken care of.

It's giving them and other potential contributors to give more.

So is having a second tier labelled silver sponsors, with smaller logos, but I missed that FB are only Bronze, thought they were silver, so it isn't necessary.

The CEA one should link probably to their site rather than OC.

I missed that this redirects to the sponsor, rather then to their OC profile page, so yes, it's fine.

@oliviertassinari
Copy link
Member Author

It works as well without the shadow.

I agree. I think that it's much better without the shadow. What about reducing the contrast between the white and the grey? So we can soften the container borders.

I think you're missing that the purpose of this section os to promote the sponsors. The sponsorship opportunity is implicit. Links to Patreon and OC is enough.

Yeah, why not. I was following webpack here but I have no objection to go into vue side.

Yes, I guessed the motivation. It's taken care of.

It's more implicit in your proposal. I do prefer the vue approach:
capture d ecran 2018-03-14 a 09 58 11

@mbrookes
Copy link
Member

What about reducing the contrast between the white and the grey?

I thought the same - it was just a mockup.

I do prefer the vue approach

Perhaps when there are enough sponsors to justify the distinction?

@oliviertassinari oliviertassinari merged commit 271244c into mui:v1-beta Mar 14, 2018
@oliviertassinari oliviertassinari deleted the improve-onboarding branch March 14, 2018 20:39
@oliviertassinari
Copy link
Member Author

@mbrookes I'm moving forward. I'm going to complete #10616. I have added a white border to make the separation cleaner. I'm not opposed to the other changes you are suggesting, but I don't see them clearly improving the situation. I will spend my energy on different topics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants