[typescript] Remove xxxClassName props from type declarations #10644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Mar 14, 2018
|
@lukePeavey Perfect :) |
|
@oliviertassinari shouldn't the class keys have been updated as part of this PR? |
|
@ianschmitz Do we miss some? |
|
Hmm i may be misunderstanding the usage. It looks like:
|
@ianschmitz Your right, those are missing from classKey. @oliviertassinari, I can submit another PR to fix that. |
@lukePeavey It would be great :)! |
@ianschmitz These keys don't exist. Given the TextField is a simple wrapper piping the properties between the FormControl, InputLabel, Input, etc. It doesn't come with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10636. I removed all the props that were changed in #10600. Let me know if there is anything I need to add/change.