Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FromHelperText] Add missing component prop definition #10658

Merged
merged 1 commit into from Mar 15, 2018
Merged

[FromHelperText] Add missing component prop definition #10658

merged 1 commit into from Mar 15, 2018

Conversation

franklixuefei
Copy link
Contributor

@franklixuefei franklixuefei commented Mar 15, 2018

Closes #10657

Please take a look. @oliviertassinari @pelotom
Thanks!

@franklixuefei franklixuefei changed the title Added component prop under FromHelperTextProps in FormHelperText.d.ts [Typescript] Added component prop under FromHelperTextProps in FormHelperText.d.ts Mar 15, 2018
@pelotom
Copy link
Member

pelotom commented Mar 15, 2018

Thanks! You mentioned that the docs need updating too, would you like to add that to this PR?

@franklixuefei
Copy link
Contributor Author

franklixuefei commented Mar 15, 2018

@pelotom NVM I double checked and the doc has been updated :-) I'll fix the title

@oliviertassinari oliviertassinari changed the title [Typescript] Added component prop under FromHelperTextProps in FormHelperText.d.ts [typescript] Added component prop under FromHelperTextProps in FormHelperText.d.ts Mar 15, 2018
@oliviertassinari oliviertassinari changed the title [typescript] Added component prop under FromHelperTextProps in FormHelperText.d.ts [typescript] Add component prop under FromHelperTextProps Mar 15, 2018
@oliviertassinari oliviertassinari merged commit e0f771a into mui:v1-beta Mar 15, 2018
@oliviertassinari oliviertassinari changed the title [typescript] Add component prop under FromHelperTextProps [FromHelperTextProps] Add missing component prop definition Mar 17, 2018
@oliviertassinari oliviertassinari changed the title [FromHelperTextProps] Add missing component prop definition [FromHelperText] Add missing component prop definition Mar 17, 2018
@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label Mar 17, 2018
@franklixuefei franklixuefei deleted the frank/typefix branch March 27, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants