Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DialogActions] Add missing TypeScript property #10674

Merged
merged 2 commits into from Mar 16, 2018
Merged

[DialogActions] Add missing TypeScript property #10674

merged 2 commits into from Mar 16, 2018

Conversation

youngnicks
Copy link
Contributor

@youngnicks youngnicks commented Mar 16, 2018 •
edited by oliviertassinari

Closes #10668

@youngnicks youngnicks mentioned this pull request Mar 16, 2018
Closed
1 task
franklixuefei
franklixuefei approved these changes Mar 16, 2018
View reviewed changes
src/Dialog/DialogActions.d.ts Outdated
@@ -1,8 +1,11 @@
import * as React from 'react';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra line.

@oliviertassinari oliviertassinari changed the title Add missing TypeScript property. [DialogActions] Add missing TypeScript property Mar 16, 2018
@oliviertassinari oliviertassinari added component: dialog This is the name of the generic UI component, not the React module! typescript labels Mar 16, 2018
@oliviertassinari
Copy link
Member

@franklixuefei Thanks for the review
@youngnicks It's a great first-time pull request 👌🏻. Thank you for giving it a shot!

@oliviertassinari oliviertassinari merged commit 14c6a04 into mui:v1-beta Mar 16, 2018
@youngnicks youngnicks deleted the Issue-10668 branch March 16, 2018 11:45
This was referenced Mar 19, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklixuefei franklixuefei franklixuefei approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youngnicks @oliviertassinari @franklixuefei