Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] make Select's onChange prop optional #11041

Merged
merged 1 commit into from Apr 17, 2018
Merged

[typescript] make Select's onChange prop optional #11041

merged 1 commit into from Apr 17, 2018

Conversation

nmchaves
Copy link
Contributor

This PR is a follow-up to #11012, which caused the Select component's onChange prop to be required in TypeScript. However, the SelectInput component's onChange prop is optional. This PR uses a Pick to ensure that the Select component's onChange has exactly the same typing as the SelectInput.

@oliviertassinari oliviertassinari merged commit e85802d into mui:v1-beta Apr 17, 2018
@oliviertassinari
Copy link
Member

@nmchaves Thanks!

@nmchaves nmchaves deleted the optional-select-onchange branch April 17, 2018 21:03
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2022
Open
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Nov 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmchaves @oliviertassinari