Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] Allow div props on InputAdornment in TypeScript #11077

Merged
merged 2 commits into from Apr 20, 2018

Conversation

mtandersson
Copy link
Contributor

@mtandersson mtandersson commented Apr 20, 2018

The following code in typescript gives a error on onClick that it is not an property in the InputAdornment.

<InputAdornment position="end" onClick={() => alert('Hello')}>
  Hello
</InputAdornment>

This pr aims to fix that.

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! typescript labels Apr 20, 2018
@oliviertassinari oliviertassinari self-assigned this Apr 20, 2018
@oliviertassinari oliviertassinari changed the title [Input] Allow div props on InputAdornment in typescript [Input] Allow div props on InputAdornment in TypeScript Apr 20, 2018
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Apr 20, 2018
@oliviertassinari oliviertassinari merged commit ad628c8 into mui:v1-beta Apr 20, 2018
@oliviertassinari
Copy link
Member

@mtandersson It's a great first-time pull request 👌🏻. Thank you for giving it a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants