[Input] Fix infinite rendering loop #11159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 馃悰
oliviertassinari
force-pushed
the
textarea-fix-infinite-loop
branch
from
90f7b0e
to
e96dc43
Compare
oliviertassinari
force-pushed
the
textarea-fix-infinite-loop
branch
from
e96dc43
to
418c425
Compare
oliviertassinari
force-pushed
the
textarea-fix-infinite-loop
branch
from
418c425
to
593ce92
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was challenging to fix. I believe there is an obscure rendering issue in Firefox that makes the
.scrollHeightvalue unstable. I ended up using a1pxthreshold for updating the height of the input. This should be 馃挴 fine like this :).Closes #11132