[ListItem] Take the focusVisibleClassName property into account #11451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
previously requested changes
May 17, 2018
oliviertassinari
changed the title
ianschmitz
reviewed
May 17, 2018
| @@ -105,7 +106,7 @@ class ListItem extends React.Component { | |||
|
|
|||
| if (button) { | |||
| componentProps.component = componentProp || 'div'; | |||
| componentProps.focusVisibleClassName = classes.focusVisible; | |||
| componentProps.focusVisibleClassName = classnames(classes.focusVisible, focusVisibleClassName); | |||
There was a problem hiding this comment.
This should be classNames(...) (capitalized N).
|
@rdemirov Thank you! |
|
@rdemirov You forgot to update the Typescript definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges the focusVisible css class with the focusVisibleClassName property
Closes #11432