[DropDownMenu] not trigger event on the page when clicking away #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hai-cea Fix. This is much better! This also prevent expensive and useless render on touch event when the dropdownmenu is closed. (I can see the difference on cordova) |
oliviertassinari
changed the title
| menuItemStyle={this.mergeAndPrefix(styles.menuItem, this.props.menuItemStyle)} | ||
| hideable={true} | ||
| visible={this.state.open} | ||
| onRequestClose={this._onMenuRequestClose} | ||
| onItemTap={this._onMenuItemClick} /> | ||
| {this.state.open && <div style={styles.overlay} onTouchTap={this._onTouchTapOverlay} />} |
There was a problem hiding this comment.
@oliviertassinari Very nice solution! Just have a small naming change on this line. For event handling I usually use: _handleOverlayTouchTap.
Sorry for the extra commit, done from my phone.
|
@hai-cea okey |
hai-cea
added a commit
that referenced
this pull request
Jul 17, 2015
[DropDownMenu] not trigger event on the page when clicking away
|
Thanks @oliviertassinari 👍 |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Fix persian examples * Remove injected css after front-end mount * Determine and apply styles for current orientation * Add tests * Support landscape for TimePicker * Use isomorphic effect for event handler * Fix lint errors * Add new props to the documentation * Fix displaying short weekdays in datepicker toolbar
This was referenced Apr 13, 2021
This was referenced Apr 26, 2021
zannager
added
the
component: menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1174.