Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LeftNav] Fixed missing onNavOpen event. #1225

Merged
merged 1 commit into from
Jul 22, 2015
Merged

[LeftNav] Fixed missing onNavOpen event. #1225

merged 1 commit into from
Jul 22, 2015

Conversation

maoziliang
Copy link
Contributor

Not trigger onNavOpen after swiping to open the LeftNav

Not trigger onNavOpen after swiping to open the `LeftNav`
@maoziliang
Copy link
Contributor Author

This because the open state is not correctly set. We can not set open to true just for showing the overlay. Open or not hasn't become a reality.

@pomerantsev
Copy link
Contributor

This seemingly simple component is becoming more and more convoluted, but this is a necessary fix if you support onNavOpen.
And I agree that #1222 should also be addressed - not everyone might need this behavior.

hai-cea added a commit that referenced this pull request Jul 22, 2015
[LeftNav] Fixed missing onNavOpen event.
@hai-cea hai-cea merged commit 178b9ef into mui:master Jul 22, 2015
@hai-cea
Copy link
Member

hai-cea commented Jul 22, 2015

Thanks @maoziliang @pomerantsev

@zannager zannager added the docs Improvements or additions to the documentation label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants