[AppBar] Fix flexbox styling in Safari #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-cea
added a commit
that referenced
this pull request
Jul 22, 2015
[AppBar] Fix flexbox styling in Safari
|
Thanks @elgerlambert |
|
Thanks @hai-cea and you're welcome! FYI: Not sure if you're already aware, but it's good to know potential issues that might arise by setting the display value in this way, see Paul's (zpao) comment here: facebook/react#2020 (comment) There doesn't appear to be any inline alternatives atm. As far as hacks go I think this is quite an elegant one for now. But be aware that things might break when react moves to using |
|
Thanks @elgerlambert - that's good to know! |
zannager
added
the
component: app bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1212