[Slider] fix Slider.jsx wrong props.value check #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,8 +78,7 @@ let Slider = React.createClass({ | |||
| }, | |||
|
|
|||
| getInitialState() { | |||
| let value = this.props.value; | |||
| if (value === null) value = this.props.defaultValue; | |||
| let value = this.props.value || this.props.defaultValue || 0; | |||
| @@ -94,7 +93,7 @@ let Slider = React.createClass({ | |||
| }, | |||
|
|
|||
| componentWillReceiveProps(nextProps) { | |||
| if (nextProps.value !== null) { | |||
| if (!nextProps.value) { | |||
There was a problem hiding this comment.
Does this break if nextProps.value === 0?
There was a problem hiding this comment.
Sure, and it is kind of problematic for the value field.
But then I was wondering, why did you guys have a check for null? Because to me, if no value is sent in a prop, it will always be undefined.
Would there be a problem in doing :
nextProps.value !== undefinedeverywhere ?
There was a problem hiding this comment.
I don't see a problem with your fix. This was probably a bug that's been in this component from the beginning.
hai-cea
added a commit
that referenced
this pull request
Jul 28, 2015
[Slider] fix Slider.jsx wrong props.value check
|
Thanks @micaste |
zannager
added
the
component: slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.