[docs] Consistent content height in Albumn layout example #12556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbrookes I'm missing something. What problem is this CSS fixing? |
|
Like the description says - it prevents the layout braking if the text in the Card content is of differing lengths, making the CardContent, and therefore the Cards differing heights. Try editing the text in one of the cards with and without this fix. Edit: working example is the layouts page itself: https://material-ui.com/page-layout-examples/ No idea what's up with CI though... |
|
Try editing the text in one of the cards with and without this fix.
Yes, it's what I have tried. I couldn't see a difference.
|
|
Before: After: Working example:
Working example with these styles removed:
|
oliviertassinari
approved these changes
Aug 21, 2018
|
💃 |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the layout breaking if the text is of differing heights.