Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Warn about checking for version mismatch #12601

Merged
merged 6 commits into from Aug 21, 2018

Conversation

hluedeke
Copy link
Contributor

@hluedeke hluedeke commented Aug 20, 2018

… between the client and server when doing SSR.

First discussed in #12434

Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small tweak. Looks good otherwise. 👍

@@ -244,3 +249,21 @@ function handleRender(req, res) {
// Render the component to a string.
const html = renderToString(
```

The second thing to look at is to verify that your client and server are running the **same exact
version** of Material UI. It is possible that a mismatch of even minor versions can cause styling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"exactly the same version"

@hluedeke
Copy link
Contributor Author

Done.

@oliviertassinari oliviertassinari changed the title Updates the docs to include checking for MUI version mismatch between… [docs] Warn about checking for version mismatch Aug 21, 2018
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 21, 2018
@oliviertassinari oliviertassinari merged commit bb5d827 into mui:master Aug 21, 2018
@oliviertassinari
Copy link
Member

@hluedeke It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot!

@hluedeke
Copy link
Contributor Author

Thank you for letting me! Glad I could help! And hope I can help more in the future 👍

@hluedeke hluedeke deleted the docs-ssr-version-mismatch branch August 21, 2018 20:25
marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
* Updates the docs to include checking for MUI version mismatch between the client and server when doing SSR.

* Markdown style update to properly show diff

* Grammar edit

* Update server-rendering.md

* Update server-rendering.md

* Update server-rendering.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants